Arm backend: Match fp32->int32 cast between pytorch and TOSA's CAST #12243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pytorch .to() truncates values toward zeros, while TOSA's CAST
rounds values to the nearest int. They will show different
behaviours on fp32->int32 casting.
- Fix the mismatched behaviour with the following transformation:
Before:
output = to_copy(x, torch.int32)
After:
is_non_negative = x >= 0
floor_x = floor(x)
ceil_x = ceil(x)
decorated_x = where(is_non_negative, floor_x, ceil_x)
output = to_copy(decorated_x, torch.int32)
Change-Id: I21286432eeb0a5e2f21865f3ac097051c921a9b3
Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
YufengShi-dudu
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12243
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 4 Unrelated FailuresAs of commit 4e19b63 with merge base b342f83 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
output = to_copy(x, torch.int32)
After:
is_non_negative = x >= 0
floor_x = floor(x)
ceil_x = ceil(x)
decorated_x = where(is_non_negative, floor_x, ceil_x)
output = to_copy(decorated_x, torch.int32)
Change-Id: I21286432eeb0a5e2f21865f3ac097051c921a9b3
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218